lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime_cfg
Date


> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Tuesday, February 28, 2023 7:07 PM
> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Abaci Robot <abaci@linux.alibaba.com>
> Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime_cfg
>
> On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote:
> > Variable bcntime_cfg is not effectively used, so delete it.
> >
> > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not
> used.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Hi Jiapeng Chong,
>
> this looks good to me.
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> While reviewing this gcc 12.2.0 told me:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs'
> [-Werror=unused-variable]
> 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf;
> | ^~~~~~~
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw'
> [-Werror=unused-variable]
> 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf;
> | ^~~~~~
>
> So perhaps you could consider sending another patch to remove them too.
>

These errors are introduced by this patch, so please fix them together by this
patch.

Ping-Ke


\
 
 \ /
  Last update: 2023-03-27 00:39    [W:0.122 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site