lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 10/10] dt-bindings: Add documentation for rt5033 mfd, regulator and charger
    Date

    On Tue, 28 Feb 2023 23:32:27 +0100, Jakob Hauser wrote:
    > Add device tree binding documentation for rt5033 multifunction device, voltage
    > regulator and battery charger.
    >
    > Cc: Beomho Seo <beomho.seo@samsung.com>
    > Cc: Chanwoo Choi <cw00.choi@samsung.com>
    > Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
    > ---
    > .../bindings/mfd/richtek,rt5033.yaml | 102 ++++++++++++++++++
    > .../power/supply/richtek,rt5033-charger.yaml | 76 +++++++++++++
    > .../regulator/richtek,rt5033-regulator.yaml | 45 ++++++++
    > 3 files changed, 223 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/mfd/richtek,rt5033.yaml
    > create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml
    > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5033-regulator.yaml
    >

    My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    on your patch (DT_CHECKER_FLAGS is new in v5.13):

    yamllint warnings/errors:

    dtschema/dtc warnings/errors:
    ./Documentation/devicetree/bindings/mfd/richtek,rt5033.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/power/supply/richtek,rt5033-charger.yaml
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-threshold-uvolt: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-threshold-uvolt: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-threshold-uvolt: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,const-uvolt: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,const-uvolt: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,const-uvolt: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,eoc-uamp: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,eoc-uamp: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,eoc-uamp: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,fast-uamp: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,fast-uamp: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,fast-uamp: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-uamp: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-uamp: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml: properties:richtek,pre-uamp: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    Documentation/devicetree/bindings/mfd/richtek,rt5033.example.dts:23.15-66.11: Warning (unit_address_vs_reg): /example-0/i2c@0: node has a unit name, but no reg or ranges property
    Documentation/devicetree/bindings/mfd/richtek,rt5033.example.dts:68.15-78.11: Warning (unit_address_vs_reg): /example-0/i2c@1: node has a unit name, but no reg or ranges property

    doc reference errors (make refcheckdocs):

    See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/a698f524106e0eb7db5cbd7e73e77ecd5ac8ad7f.1677620677.git.jahau@rocketmail.com

    The base for the series is generally the latest rc1. A different dependency
    should be noted in *this* patch.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit after running the above command yourself. Note
    that DT_SCHEMA_FILES can be set to your schema file to speed up checking
    your schema. However, it must be unset to test all examples with your schema.

    \
     
     \ /
      Last update: 2023-03-27 00:39    [W:3.032 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site