Messages in this thread | | | Date | Mon, 27 Feb 2023 17:23:09 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 4/5] spi: Add support for Intel LJCA USB SPI driver |
| |
On Sat, Feb 25, 2023 at 10:01:17PM +0800, Ye Xiang wrote:
> +struct spi_xfer_packet { > + u8 indicator; > + s8 len; > + u8 data[]; > +} __packed;
> +static int ljca_spi_read_write(struct ljca_spi_dev *ljca_spi, const u8 *w_data, u8 *r_data, int len, > + int id, int complete, int cmd) > +{ > + struct spi_xfer_packet *w_packet = (struct spi_xfer_packet *)ljca_spi->obuf; > + struct spi_xfer_packet *r_packet = (struct spi_xfer_packet *)ljca_spi->ibuf; > + unsigned int ibuf_len = LJCA_SPI_BUF_SIZE; > + int ret; > + > + w_packet->indicator = FIELD_PREP(LJCA_SPI_XFER_INDICATOR_ID, id) | > + FIELD_PREP(LJCA_SPI_XFER_INDICATOR_CMPL, complete) | > + FIELD_PREP(LJCA_SPI_XFER_INDICATOR_INDEX, > + ljca_spi->spi_info->id); > + > + if (cmd == LJCA_SPI_READ) { > + w_packet->len = sizeof(u16); > + *(u16 *)&w_packet->data[0] = len;
Are there no endianness considerations here?
> +static int ljca_spi_transfer(struct ljca_spi_dev *ljca_spi, const u8 *tx_data, > + u8 *rx_data, u16 len) > +{
This function has one caller with barely anything in it - perhaps just inline it? [unhandled content-type:application/pgp-signature] | |