Messages in this thread | | | Date | Mon, 27 Feb 2023 17:34:52 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH AUTOSEL 5.10 4/5] fs/super.c: stop calling fscrypt_destroy_keyring() from __put_super() |
| |
Hi!
> From: Eric Biggers <ebiggers@google.com> > > [ Upstream commit ec64036e68634231f5891faa2b7a81cdc5dcd001 ] > > Now that the key associated with the "test_dummy_operation" mount option > is added on-demand when it's needed, rather than immediately when the > filesystem is mounted, fscrypt_destroy_keyring() no longer needs to be > called from __put_super() to avoid a memory leak on mount failure. > > Remove this call, which was causing confusion because it appeared to be > a sleep-in-atomic bug (though it wasn't, for a somewhat-subtle > reason).
Not a bugfix, so should not be in -stable. Plus, have someone verified that its dependencies are in 5.10?
Best regards, Pavel > +++ b/fs/super.c > @@ -293,7 +293,6 @@ static void __put_super(struct super_block *s) > WARN_ON(s->s_inode_lru.node); > WARN_ON(!list_empty(&s->s_mounts)); > security_sb_free(s); > - fscrypt_destroy_keyring(s); > put_user_ns(s->s_user_ns); > kfree(s->s_subtype); > call_rcu(&s->rcu, destroy_super_rcu);
-- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] | |