Messages in this thread | | | From | Björn Töpel <> | Subject | Re: [PATCH bpf v2] riscv, bpf: fix patch_text implicit declaration | Date | Mon, 27 Feb 2023 08:31:01 +0100 |
| |
Randy Dunlap <rdunlap@infradead.org> writes:
> bpf_jit_comp64.c uses patch_text(), so add <asm/patch.h> to it > to prevent the build error: > > ../arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke': > ../arch/riscv/net/bpf_jit_comp64.c:691:23: error: implicit declaration of function 'patch_text'; did you mean 'path_get'? [-Werror=implicit-function-declaration] > 691 | ret = patch_text(ip, new_insns, ninsns); > | ^~~~~~~~~~ > > Fixes: 596f2e6f9cf4 ("riscv, bpf: Add bpf_arch_text_poke support for RV64") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/r/202302271000.Aj4nMXbZ-lkp@intel.com > Cc: Pu Lehui <pulehui@huawei.com> > Cc: Luke Nelson <luke.r.nels@gmail.com> > Cc: Xi Wang <xi.wang@gmail.com> > Cc: bpf@vger.kernel.org > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: John Fastabend <john.fastabend@gmail.com> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: "Björn Töpel" <bjorn@kernel.org> > Cc: linux-riscv@lists.infradead.org > --- > v2: add header file directly to bpf_jit_comp64.c (Pu Lehui) > change patch target to bpf (for fixes)
Thanks, Randy!
For the curious; The asm/patch.h file was picked via UPROBES (via PERF_EVENTS=y). For PERF_EVENTS=n, you get the build error.
Acked-by: Björn Töpel <bjorn@rivosinc.com>
| |