lkml.org 
[lkml]   [2023]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: add a null check of kzalloc in go_add_group_info_attr
On Mon, Feb 27, 2023 at 03:11:21PM +0800, Kang Chen wrote:
> Hi, Dan,
>
> Thanks for your review.
> I noticed there is no error handling in the origin design (this call chain).
> go_add_group_info_attr returns a len-like value indicating the length
> of pbuf.
> I don't think throwing an error to the caller is a good idea, the caller
> doesn't seem to care about it.
> So inserting a netdev_dbg or pr_debug here might be enough.
> Do you have a better idea?
>

The bug is real, yes. But you have your static checker which can detect
it and I also have an unpublished static checker test which detects this
bug.

drivers/staging/r8188eu/core/rtw_p2p.c:106 go_add_group_info_attr() warn: 'pdata_attr' was never checked for NULL

If we just hide the bug enough for so that the static checker cannot
find the bug then we're taking a step backward. When this driver is
ready to leave staging then normally I review every static checker
warning. But if we hide the warning then it will never be fixed.

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.048 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site