Messages in this thread | | | From | Ulf Hansson <> | Date | Mon, 27 Feb 2023 16:29:27 +0100 | Subject | Re: [PATCH V6 05/24] mmc: core: Add definitions for SD UHS-II cards |
| |
[...]
> > > > I think this better belongs in the struct mmc_host, please move it > > there and then also rename it into "uhs2_app_cmd". Note that, there is > > also one case in mmc_sd_num_wr_blocks() that sends an MMC_APP_CMD, but > > without calling mmc_app_cmd(). This needs to be fixed. > > > > > + unsigned int power_delay_ms; /* waiting for stable power */ > > > > This seems to be unused, so let's drop it! > > > > This power_delay_ms is used in the sd_uhs2_power_up function. >
Correct. Although, the value isn't being set, which means it's always 0. Is that deliberate?
I realize that we are going to end up calling msleep(0) for this case, so there is a delay being done anyway.
[...]
Kind regards Uffe
| |