Messages in this thread | | | Date | Mon, 27 Feb 2023 08:12:16 +0100 | Subject | Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain | From | Juergen Gross <> |
| |
On 24.02.23 22:00, Boris Ostrovsky wrote: > > On 2/23/23 4:32 AM, Juergen Gross wrote: >> + >> + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { >> + op.u.read_memtype.reg = reg; >> + if (HYPERVISOR_platform_op(&op)) >> + break; > > > If we fail on the first iteration, do we still want to mark MTRRs are > enabled/set in mtrr_overwrite_state()?
Hmm, good idea.
I think we should just drop the call of mtrr_overwrite_state() in this case.
Juergen
[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |