Messages in this thread | | | Date | Mon, 27 Feb 2023 14:33:12 +0100 | From | Lorenzo Bianconi <> | Subject | Re: [PATCH] wifi: mt76: add a check of vzalloc in mt7615_coredump_work |
| |
> vzalloc may fails, dump might be null and will cause > illegal address access later.
can you please add a Fixes tag?
Regards, Lorenzo
> > Signed-off-by: Kang Chen <void0red@gmail.com> > --- > drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > index a95602473..73d84c301 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > @@ -2367,6 +2367,9 @@ void mt7615_coredump_work(struct work_struct *work) > } > > dump = vzalloc(MT76_CONNAC_COREDUMP_SZ); > + if (!dump) > + return; > + > data = dump; > > while (true) { > -- > 2.34.1 > [unhandled content-type:application/pgp-signature] | |