Messages in this thread | | | Date | Mon, 27 Feb 2023 14:43:45 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v3 02/20] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers |
| |
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on rafael-pm/thermal] [also build test ERROR on groeck-staging/hwmon-next] [cannot apply to v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230227-065829 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal patch link: https://lore.kernel.org/r/20230226225406.979703-3-daniel.lezcano%40linaro.org patch subject: [PATCH v3 02/20] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230227/202302271421.ZjVUJ4DB-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c12531f9e11ce889a1c6adaa17dfbaa04a5d74a5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230227-065829 git checkout c12531f9e11ce889a1c6adaa17dfbaa04a5d74a5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202302271421.ZjVUJ4DB-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/thermal/db8500_thermal.c: In function 'db8500_thermal_get_temp': >> drivers/thermal/db8500_thermal.c:63:42: error: implicit declaration of function 'therma_zone_device_priv'; did you mean 'thermal_zone_device_priv'? [-Werror=implicit-function-declaration] 63 | struct db8500_thermal_zone *th = therma_zone_device_priv(tz); | ^~~~~~~~~~~~~~~~~~~~~~~ | thermal_zone_device_priv drivers/thermal/db8500_thermal.c:63:42: warning: initialization of 'struct db8500_thermal_zone *' from 'int' makes pointer from integer without a cast [-Wint-conversion] cc1: some warnings being treated as errors
vim +63 drivers/thermal/db8500_thermal.c
59 60 /* Callback to get current temperature */ 61 static int db8500_thermal_get_temp(struct thermal_zone_device *tz, int *temp) 62 { > 63 struct db8500_thermal_zone *th = therma_zone_device_priv(tz); 64 65 /* 66 * TODO: There is no PRCMU interface to get temperature data currently, 67 * so a pseudo temperature is returned , it works for thermal framework 68 * and this will be fixed when the PRCMU interface is available. 69 */ 70 *temp = th->interpolated_temp; 71 72 return 0; 73 } 74
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |