Messages in this thread | | | Date | Mon, 27 Feb 2023 10:33:14 +0100 | Subject | Re: [PATCH 3/3] soc: mediatek: scpsys: Add support for MT6735 | From | AngeloGioacchino Del Regno <> |
| |
Il 25/02/23 11:16, Yassine Oudjana ha scritto: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add support for SCPSYS power domains of MT6735. All non-CPU power domains > are added except for MD2 (C2K modem), which is left out due to issues > with powering it on. >
This is a legacy driver and I'm convinced that we should do something to actually *drop it forever*.
Please add support for power domains in mtk-pm-domains.c instead: if you need a nice example about differences between the two, look at MT8173's implementation, as that is present in both scpsys and mtk-pm-domains.
Summarizing, your MT6735 support will be about: - Adding soc/mediatek/mt6735-pm-domains.h - Adding support in mtk-pm-domains:
static const struct of_device_id scpsys_of_match[] = { ........ { .compatible = "mediatek,mt6735-power-controller", .data = &mt6735_scpsys_data, }, ......... };
Cheers, Angelo
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > ---
| |