lkml.org 
[lkml]   [2023]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] soc: mediatek: scpsys: Add support for MT6735
From
Il 25/02/23 11:16, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add support for SCPSYS power domains of MT6735. All non-CPU power domains
> are added except for MD2 (C2K modem), which is left out due to issues
> with powering it on.
>

This is a legacy driver and I'm convinced that we should do something to
actually *drop it forever*.

Please add support for power domains in mtk-pm-domains.c instead: if you need
a nice example about differences between the two, look at MT8173's implementation,
as that is present in both scpsys and mtk-pm-domains.

Summarizing, your MT6735 support will be about:
- Adding soc/mediatek/mt6735-pm-domains.h
- Adding support in mtk-pm-domains:

static const struct of_device_id scpsys_of_match[] = {
........
{
.compatible = "mediatek,mt6735-power-controller",
.data = &mt6735_scpsys_data,
},
.........
};

Cheers,
Angelo

> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---

\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.073 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site