lkml.org 
[lkml]   [2023]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/4] dt-bindings: clock: Add MediaTek MT6735 clock bindings
From
On 27/02/2023 09:29, Yassine Oudjana wrote:
>
> On Mon, Feb 27 2023 at 09:18:45 AM +01:00:00, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 25/02/2023 10:42, Yassine Oudjana wrote:
>>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>>>
>>> Add clock definitions for the main clock controllers of MT6735
>>> (apmixedsys,
>>> topckgen, infracfg and pericfg).
>>>
>>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> ---
>>> MAINTAINERS | 10 +++
>>> .../clock/mediatek,mt6735-apmixedsys.h | 16 ++++
>>> .../clock/mediatek,mt6735-infracfg.h | 25 ++++++
>>> .../clock/mediatek,mt6735-pericfg.h | 37 +++++++++
>>> .../clock/mediatek,mt6735-topckgen.h | 79
>>> +++++++++++++++++++
>>> 5 files changed, 167 insertions(+)
>>
>> You should squash it with other part of binding. What is the reason
>> behind splitting one binding into three patches?
>
> It seemed logical to me that each of clock and reset bindings as well
> as documentation would be separate parts especially since they go in

I don't understand. All of these are bindings. What do you mean by
"documentation"?

> different paths, but if combining them is how it's done then sure, I'll
> squash them and resend.

They cannot go different paths and your submissions creates false
impression they can. If you want to see - apply these on separate
branches and test if: driver compiles and paths to files in doc are not
broken. Answer: driver won't compile and paths will point to
non-existing files.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.566 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site