lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] staging: rtl8712: Fixes the problem of irregular indentation
On Sun, Feb 26, 2023 at 12:28:20PM +0000, Shibo Li wrote:
> This patch fixes the problem of irregular indentation
>
> Signed-off-by: Shibo Li <zzutcyha@163.com>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 182 ++++++++++++-------------
> 1 file changed, 91 insertions(+), 91 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index fccfa0915a02..d8af4f370060 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -51,7 +51,7 @@ int r8712_init_mlme_priv(struct _adapter *padapter)
> set_scanned_network_val(pmlmepriv, 0);
> memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid));
> pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
> - GFP_ATOMIC);
> + GFP_ATOMIC);

The original was correct and the new version is incorrect. Checkpatch
will complain about the new version if you re-run checkpatch on the file
(not if you run it on the patch itself).

CHECK: Alignment should match open parenthesis
#54: FILE: drivers/staging/rtl8712/rtl871x_mlme.c:54:
+ pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
+ GFP_ATOMIC);

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.049 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site