lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.1 43/58] pinctrl: at91: use devm_kasprintf() to avoid potential leaks
    Date
    From: Claudiu Beznea <claudiu.beznea@microchip.com>

    [ Upstream commit 1c4e5c470a56f7f7c649c0c70e603abc1eab15c4 ]

    Use devm_kasprintf() instead of kasprintf() to avoid any potential
    leaks. At the moment drivers have no remove functionality thus
    there is no need for fixes tag.

    Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    Link: https://lore.kernel.org/r/20230203132714.1931596-1-claudiu.beznea@microchip.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++--
    drivers/pinctrl/pinctrl-at91.c | 2 +-
    2 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
    index 82b921fd630d5..7f193f2b1566a 100644
    --- a/drivers/pinctrl/pinctrl-at91-pio4.c
    +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
    @@ -1120,8 +1120,8 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)

    pin_desc[i].number = i;
    /* Pin naming convention: P(bank_name)(bank_pin_number). */
    - pin_desc[i].name = kasprintf(GFP_KERNEL, "P%c%d",
    - bank + 'A', line);
    + pin_desc[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "P%c%d",
    + bank + 'A', line);

    group->name = group_names[i] = pin_desc[i].name;
    group->pin = pin_desc[i].number;
    diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
    index 81dbffab621fb..ff3b6a8a0b170 100644
    --- a/drivers/pinctrl/pinctrl-at91.c
    +++ b/drivers/pinctrl/pinctrl-at91.c
    @@ -1883,7 +1883,7 @@ static int at91_gpio_probe(struct platform_device *pdev)
    }

    for (i = 0; i < chip->ngpio; i++)
    - names[i] = kasprintf(GFP_KERNEL, "pio%c%d", alias_idx + 'A', i);
    + names[i] = devm_kasprintf(&pdev->dev, GFP_KERNEL, "pio%c%d", alias_idx + 'A', i);

    chip->names = (const char *const *)names;

    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-27 00:36    [W:4.033 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site