Messages in this thread | | | Date | Sun, 26 Feb 2023 23:14:19 +0100 | Subject | Re: [PATCH 07/27] kbuild, MIPS: BCM47XX: remove MODULE_LICENSE in non-modules | From | Philippe Mathieu-Daudé <> |
| |
On 22/2/23 13:14, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: "Rafał Miłecki" <zajec5@gmail.com> > Cc: linux-mips@vger.kernel.org > --- > drivers/firmware/broadcom/bcm47xx_nvram.c | 1 - > 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| |