lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.1 38/49] time/debug: Fix memory leak with using debugfs_lookup()
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    [ Upstream commit 5b268d8abaec6cbd4bd70d062e769098d96670aa ]

    When calling debugfs_lookup() the result must have dput() called on it,
    otherwise the memory will leak over time. To make things simpler, just
    call debugfs_lookup_and_remove() instead which handles all of the logic at
    once.

    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20230202151214.2306822-1-gregkh@linuxfoundation.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/time/test_udelay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
    index 13b11eb62685e..20d5df631570e 100644
    --- a/kernel/time/test_udelay.c
    +++ b/kernel/time/test_udelay.c
    @@ -149,7 +149,7 @@ module_init(udelay_test_init);
    static void __exit udelay_test_exit(void)
    {
    mutex_lock(&udelay_test_lock);
    - debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
    + debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
    mutex_unlock(&udelay_test_lock);
    }

    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-27 00:36    [W:2.478 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site