lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.1 25/49] net: bcmgenet: Add a check for oversized packets
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit 5c0862c2c962052ed5055220a00ac1cefb92fbcd ]

    Occasionnaly we may get oversized packets from the hardware which
    exceed the nomimal 2KiB buffer size we allocate SKBs with. Add an early
    check which drops the packet to avoid invoking skb_over_panic() and move
    on to processing the next packet.

    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index 25c4506069856..f679ed54b3ef2 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -2311,6 +2311,14 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_rx_ring *ring,
    __func__, p_index, ring->c_index,
    ring->read_ptr, dma_length_status);

    + if (unlikely(len > RX_BUF_LENGTH)) {
    + netif_err(priv, rx_status, dev, "oversized packet\n");
    + dev->stats.rx_length_errors++;
    + dev->stats.rx_errors++;
    + dev_kfree_skb_any(skb);
    + goto next;
    + }
    +
    if (unlikely(!(dma_flag & DMA_EOP) || !(dma_flag & DMA_SOP))) {
    netif_err(priv, rx_status, dev,
    "dropping fragmented packet!\n");
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-27 00:36    [W:5.103 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site