Messages in this thread | | | Date | Sat, 25 Feb 2023 09:46:37 -0800 | Subject | Re: [PATCH] tty: serial: fsl_lpuart: select SERIAL_FSL_LPUART for SERIAL_FSL_LPUART_CONSOLE | From | Randy Dunlap <> |
| |
Hi--
On 2/25/23 09:39, Tom Rix wrote: > A rand config causes this link error > ld: drivers/tty/serial/earlycon.o: in function `parse_options': > drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon' > > The rand config has > CONFIG_SERIAL_CORE=m > CONFIG_SERIAL_EARLYCON=y > CONFIG_SERIAL_FSL_LPUART=m > CONFIG_SERIAL_FSL_LPUART_CONSOLE=y > > SERIAL_FSL_LPUART should have been selected instead of depends on-ed. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 625358f44419..b24d74d389fc 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1313,7 +1313,7 @@ config SERIAL_FSL_LPUART > > config SERIAL_FSL_LPUART_CONSOLE > bool "Console on Freescale lpuart serial port" > - depends on SERIAL_FSL_LPUART > + select SERIAL_FSL_LPUART
Most other _CONSOLE Kconfig have:
depends on SERIAL_FSL_LPUART=y
e.g.
but I noticed a few others with a similar problem.
> select SERIAL_CORE_CONSOLE > select SERIAL_EARLYCON > help
-- ~Randy
| |