Messages in this thread | | | Date | Fri, 24 Feb 2023 08:38:49 +0100 | From | Greg KH <> | Subject | Re: [PATCH 3/3] rust: macros: Allow specifying multiple module aliases |
| |
On Fri, Feb 24, 2023 at 04:25:57PM +0900, Asahi Lina wrote: > Modules can (and usually do) have multiple alias tags, in order to > specify multiple possible device matches for autoloading. Allow this by > changing the alias ModuleInfo field to an Option<Vec<String>>.
Note, manually specifying the MODULE_ALIAS is only really ever done for platform drivers today (and I would argue we need to fix that up), otherwise the use of MODULE_DEVICE_TABLE() should really really be used instead of having to manually specify aliases.
And why would a module alias be needed for new (i.e. rust) code anyway? You aren't trying to do any backwards-compatibility stuff yet :)
Or is this just for a platform driver? It's hard to review infrastructure changes without seeing any real users :(
thanks,
greg k-h
| |