Messages in this thread | | | Date | Fri, 24 Feb 2023 11:59:13 -0800 | Subject | Re: [PATCH v4 1/2] remoteproc: core: Export the rproc coredump APIs | From | Trilok Soni <> |
| |
On 2/24/2023 11:57 AM, Gokul krishna Krishnakumar wrote: > From: Siddharth Gupta <sidgup@codeaurora.org> > > The remoteproc coredump APIs are currently only part of the internal > remoteproc header. This prevents the remoteproc platform drivers from > using these APIs when needed. This change moves the rproc_coredump() > and rproc_coredump_cleanup() APIs to the linux header and marks them > as exported symbols. > > Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org> > Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com> > --- > drivers/remoteproc/remoteproc_coredump.c | 2 ++ > drivers/remoteproc/remoteproc_internal.h | 4 ---- > include/linux/remoteproc.h | 4 ++++ > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c > index 4b093420d98a..e8f1b580d1d9 100644 > --- a/drivers/remoteproc/remoteproc_coredump.c > +++ b/drivers/remoteproc/remoteproc_coredump.c > @@ -32,6 +32,7 @@ void rproc_coredump_cleanup(struct rproc *rproc) > kfree(entry); > } > } > +EXPORT_SYMBOL(rproc_coredump_cleanup);
EXPORT_SYMBOL_GPL?
> > /** > * rproc_coredump_add_segment() - add segment of device memory to coredump > @@ -327,6 +328,7 @@ void rproc_coredump(struct rproc *rproc) > */ > wait_for_completion(&dump_state.dump_done); > } > +EXPORT_SYMBOL(rproc_coredump);
Same as above.
| |