Messages in this thread | | | Date | Fri, 24 Feb 2023 11:50:52 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core |
| |
On Fri, 24 Feb 2023 07:39:33 +0000 Yanchao Yang (杨彦超) wrote: > > > Do you really need these flags? > > > > We will check and update if it's really redundant soon. > Update test result. > Both flags are deleted, then run the make command with > "build in" and "build module" on a separate kernel tree. Both suffer > the same build error. > “drivers/net/wan/mediatek/pcie/mtk_pci.c:16:10: fatal error: mtk_fsm.h: > No such file or directory > #include "mtk_fsm.h"" > The reason is that all files are not placed in the same folder. The > driver named TMI needs a child folder, then needs these flags. > > Any ideas or comments for this? Please help share it at your > convenience.
Relative paths work, right?
> > > Labels should be named after action they perform, not where they > > > jump > > > from. Please fix this everywhere. > > > > We can found similar samples in kernel codes, naming the label per > > where jump from… > > ex. pci-sysfs.c > > shall we apply this rule to our driver? > > I > > t's mandatory or nice to have. > > Any ideas or comments for this? Please help share it at your > convenience.
It's mandatory for new code.
| |