lkml.org 
[lkml]   [2023]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCH v3 15/32] x86/fred: make unions for the cs and ss fields in struct pt_regs
Date
> > +	union {
> > + unsigned long csl; /* CS + any fields above it */
>
> I guess that CSL here is supposed to mean cs long, but CSL (Current Stack Level) is a
> new term in the FRED spec which isn't this.

Good catch!

>
> This causes changes such as the final hunk in patch 27 to read incorrectly, despite
> being technically correct.
>
> cs_slot would be much clearer in code, but tbh, even cs_l would be better than the
> version without an underscore.

cs_slot sounds a good term unless someone comes up with a better one.

>
> And obviously, whatever is done here should be mirrored for ss.

Probably ss_slot then.
Xin
\
 
 \ /
  Last update: 2023-03-27 00:35    [W:0.066 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site