Messages in this thread | | | Date | Fri, 24 Feb 2023 11:02:58 -0500 | From | Gregory Price <> | Subject | Re: [PATCH v11 2/2] ptrace,syscall_user_dispatch: checkpoint/restore support for SUD |
| |
On Fri, Feb 24, 2023 at 12:17:56AM -0800, Andrei Vagin wrote: > WARNING: Missing a blank line after declarations > > You need to verify all patches with ./scripts/checkpatch.pl. Here are > a few other warnings. >
I completely neglected this, aye aye
> > diff --git a/tools/testing/selftests/ptrace/get_set_sud.c b/tools/testing/selftests/ptrace/get_set_sud.c > > I think the test has to be in a separate patch. >
will split
> > + if (ret < 0) { > > + ASSERT_EQ(errno, EIO); > > When do we expect to get EIO here? >
artifact from an old version i never dropped, had to do with my include paths being messed up and not being able to include linux/ptrace.h for some reason. Will drop
~Gregory
| |