Messages in this thread | | | Date | Fri, 24 Feb 2023 08:00:57 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() |
| |
On 2/23/23 20:53, Oleksij Rempel wrote: > Hallo Guenter, > > On Thu, Feb 23, 2023 at 08:16:04PM -0800, Guenter Roeck wrote: >> On Thu, Feb 23, 2023 at 07:55:55PM -0800, Guenter Roeck wrote: >>> On Sat, Feb 11, 2023 at 08:41:10AM +0100, Oleksij Rempel wrote: >>>> Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). >>>> >>>> It should work as before except write operation to the EEE adv registers >>>> will be done only if some EEE abilities was detected. >>>> >>>> If some driver will have a regression, related driver should provide own >>>> .get_features callback. See micrel.c:ksz9477_get_features() as example. >>>> >>>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >>>> Reviewed-by: Andrew Lunn <andrew@lunn.ch> >>> >>> This patch causes network interface failures with all my xtensa qemu >>> emulations. Reverting it fixes the problem. Bisect log is attached >>> for reference. >>> >> >> Also affected are arm:cubieboard emulations, with same symptom. >> arm:bletchley-bmc emulations crash. In both cases, reverting this patch >> fixes the problem. > > Please test this fixes: > https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ >
Applied and tested
77c39beb5efa (HEAD -> master) net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes 068a35a8d62c net: phy: do not force EEE support 66d358a5fac6 net: phy: c45: add genphy_c45_an_config_eee_aneg() function ecea1bf8b04c net: phy: c45: use "supported_eee" instead of supported for access validation
on top of
d2980d8d8265 (upstream/master, origin/master, origin/HEAD, local/master) Merge tag 'mm-nonmm-stable-2023-02-20-15-29' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
No change for xtensa and arm:cubieboard; network interfaces still fail. On the plus side, the failures with arm:bletchley-bmc (warnings, crash) are longer seen.
Guenter
| |