Messages in this thread | | | Date | Fri, 24 Feb 2023 15:34:39 +0200 | From | Svyatoslav Ryhel <> | Subject | Re: [PATCH v1 1/5] ARM: tegra: Add labels to tegra30.dtsi |
| |
22 лютого 2023 р. 10:56:23 GMT+02:00, Mikko Perttunen <cyndis@kapsi.fi> написав(-ла): >On 2/21/23 19:53, Svyatoslav Ryhel wrote: >> From: Michał Mirosław <mirq-linux@rere.qmqm.pl> >> >> Add phandle names for memory/I2C/SPI/USB/SDMMC controller nodes to allow >> for cleaner device descriptions. >> >> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- > >Hi! > >Patches 1 and 2 are missing your Signed-off-by. But also, I'd only add labels as they are needed instead of adding them all in one go. > >Mikko >
Thanks for suggestions. I may agree about labels, but it eventually will get to stage when all labels from patches will be added. So why not add them in one commit instead of making a dozen more with adding one label a time.
Best regards, Svyatoslav R.
| |