lkml.org 
[lkml]   [2023]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 02/16] arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu constraints
    From
    Il 24/02/23 10:50, Chen-Yu Tsai ha scritto:
    > On Thu, Feb 23, 2023 at 9:43 PM AngeloGioacchino Del Regno
    > <angelogioacchino.delregno@collabora.com> wrote:
    >>
    >> Override the PMIC-default voltage constraints for VGPU and VSRAM_GPU
    >> with the platform specific vmin/vmax for the highest possible SoC
    >> binning.
    >
    > The maximum voltage numbers don't match the existing OPP table though.

    The OPP table that we've got in mt8183.dtsi does not declare frequencies for the
    highest binning for this SoC, I guess because there was no way to check fuses to
    restrict the table to bin XYZ.

    These maximum voltages are - true - higher compared to the highest voltage in
    the GPU OPP table, but they're still in spec (check datasheets!).

    Should I reword the commit description?

    Regards,
    Angelo

    >
    >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    >> ---
    >> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 6 ++++++
    >> 1 file changed, 6 insertions(+)
    >>
    >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
    >> index de9778c85b94..63952c1251df 100644
    >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
    >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
    >> @@ -401,6 +401,9 @@ &mt6358codec {
    >> };
    >>
    >> &mt6358_vgpu_reg {
    >> + regulator-min-microvolt = <625000>;
    >> + regulator-max-microvolt = <900000>;
    >> +
    >> regulator-coupled-with = <&mt6358_vsram_gpu_reg>;
    >> regulator-coupled-max-spread = <100000>;
    >> };
    >> @@ -416,6 +419,9 @@ &mt6358_vsim2_reg {
    >> };
    >>
    >> &mt6358_vsram_gpu_reg {
    >> + regulator-min-microvolt = <850000>;
    >> + regulator-max-microvolt = <1000000>;
    >> +
    >> regulator-coupled-with = <&mt6358_vgpu_reg>;
    >> regulator-coupled-max-spread = <100000>;
    >> };
    >> --
    >> 2.39.2
    >>

    \
     
     \ /
      Last update: 2023-03-27 00:34    [W:4.262 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site