lkml.org 
[lkml]   [2023]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] regmap-irq: Place kernel doc of struct regmap_irq_chip in order
On Wed, Feb 22, 2023 at 11:43:28AM -0500, William Breathitt Gray wrote:
> On Mon, Feb 20, 2023 at 05:33:34PM +0200, Andy Shevchenko wrote:
> > It seems that a couple of members got lost theirorder, put them back.
>
> Looks like a typographical error here: "theirorder".

Ah, thanks!

...

> > unsigned int use_ack:1;
> > unsigned int ack_invert:1;
> > unsigned int clear_ack:1;
> > + unsigned int status_invert:1;
> > unsigned int wake_invert:1;
> > - unsigned int runtime_pm:1;
> > unsigned int type_in_mask:1;
> > unsigned int clear_on_unmask:1;
> > + unsigned int runtime_pm:1;
> > unsigned int not_fixed_stride:1;
> > - unsigned int status_invert:1;
>
> These don't look alphabetical, so what is the order for these?

Nope, the order is to follow:
a) kernel doc
b) semantics of each of the groups

Do you think the order can be improved? Can you point out how?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-03-27 00:34    [W:0.096 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site