lkml.org 
[lkml]   [2023]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/7] scsi: ufs: core: Fix mcq nr_hw_queues
Date
Okay, I will add a comment here in next update. :)

On Thu, 2023-02-23 at 18:32 +0800, Ziqi Chen wrote:
> Hi Po-Wen,
>
> On 2/22/2023 11:04 AM, Po-Wen Kao wrote:
> > Need to add one to MAXQ to obtain number of hardware queue.
> >
> > Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com>
> > ---
> > drivers/ufs/core/ufs-mcq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-
> > mcq.c
> > index a39746b2a8be..5d5bc0bc6e88 100644
> > --- a/drivers/ufs/core/ufs-mcq.c
> > +++ b/drivers/ufs/core/ufs-mcq.c
> > @@ -150,7 +150,7 @@ static int ufshcd_mcq_config_nr_queues(struct
> > ufs_hba *hba)
> > u32 hba_maxq, rem, tot_queues;
> > struct Scsi_Host *host = hba->host;
> >
> > - hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities);
> > + hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1
> > ;
>
> Can we add one line comment why need to add one to hba_maxq here or
> in
> commit message?
> >
> > tot_queues = UFS_MCQ_NUM_DEV_CMD_QUEUES + read_queues +
> > poll_queues +
> > rw_queues;
>
> Best Regards.
>
> Ziqi
>
\
 
 \ /
  Last update: 2023-03-27 00:33    [W:0.089 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site