lkml.org 
[lkml]   [2023]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RFC 3/4] dt-bindings: clock: break out mediatek,filogic-apmixed
From
On 22/02/2023 19:09, Daniel Golle wrote:
> The apmixed clocks of MT7981 and MT7986 are identical. In order to
> de-duplicate both clock drivers, start with putting apmixed into a
> header files of its own, so it can be used by both SoCs.
> Propagate this change also to mt7986a.dtsi which is the only user.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 +
> drivers/clk/mediatek/clk-mt7986-apmixed.c | 2 +-
> .../clock/mediatek,filogic-apmixed.h | 21 +++++++++++++++++++
> .../dt-bindings/clock/mediatek,mt7981-clk.h | 10 ---------
> .../dt-bindings/clock/mediatek,mt7986-clk.h | 11 ----------
> 5 files changed, 23 insertions(+), 22 deletions(-)

Same comments as previous patch:
1. Too generic name.
2. Mixed code with bindings with DTS.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-27 00:33    [W:0.032 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site