Messages in this thread | | | From | Benjamin Tissoires <> | Date | Thu, 23 Feb 2023 10:28:11 +0100 | Subject | Re: [GIT PULL] HID for 6.3 |
| |
On Wed, Feb 22, 2023 at 8:24 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Wed, Feb 22, 2023 at 2:16 AM Benjamin Tissoires > <benjamin.tissoires@redhat.com> wrote: > > > > - HID-BPF infrastructure: this allows to start using HID-BPF. > > I really don't think this should default to being enabled when there > doesn't seem to be any actual useful use-cases for it. > > So why does it have that > > default HID_SUPPORT > > that turns it on if HID is on, and > > If unsure, say Y. > > in the help message? > > I check for these things, because developers always think that THEIR > code is so magically important and everybody should care. And that's > simply not true. If we have been able to do without HID_BPF before, > then it certainly didn't magically become important for everybody just > by virtue of existing. > > The *only* things that should be "default y" are basically new gating > questions (like the new gating question of "do you want HID at all", > when we didn't use to even ask), or things that cure cancer or solve > world hunger.
I was about to send an apology email with a patch to remove that line but then I realized that you already got rid of the default Y.
So apologies for that. I mainly wanted this to be enabled in general distribution where users encounter issues with HID devices, but it's clear that it wasn't a good choice as servers will probably never have a need for it.
And thanks for fixing it while applying the series.
Cheers, Benjamin
> > Linus >
| |