Messages in this thread | | | Date | Wed, 22 Feb 2023 12:12:55 -0800 | Subject | Re: [PATCH v2 4/7] platform/x86/intel/ifs: Implement Array BIST test | From | Dave Hansen <> |
| |
On 2/15/23 13:13, Joseph, Jithu wrote: > And for the last argument, we need to dump the whole 64 bits within "command" > into trace output .
No, no you don't.
Just split it up in to human-readable logical pieces. You don't need to dump the whole 'command'. If you want to trace the completion mask, then extract the mask and print *that* with a proper field name.
I actually really think this tracing should go away, *ESPECIALLY* if you insist on dumping out raw, non-human-readable MSR values.
I say NAK on the tracing. You haven't convinced me that it's necessary on top of what we have today (MSR tracing).
| |