lkml.org 
[lkml]   [2023]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 03/16] thermal: Remove debug or error messages in get_temp() ops
    From
    On 2/21/23 10:06, Daniel Lezcano wrote:
    > Some get_temp() ops implementation are showing an error or a debug
    > message if the reading of the sensor fails.
    >
    > The debug message is already displayed from the call site of this
    > ops. So we can remove it.
    >
    > On the other side, the error should not be displayed because in
    > production that can raise tons of messages.
    >
    > Finally, some drivers are showing a debug message with the
    > temperature, this is also accessible through the trace from the core
    > code in the temperature_update() function.
    >
    > Another benefit is the dev_* messages are accessing the thermal zone
    > device field from the structure, so we encapsulate even more the code
    > by preventing these accesses.
    >
    > Remove those messages.
    >
    > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> #Armada

    Acked-by: Florian Fainelli <f.fainelli@gmail.com> #brcmstb_thermal.c
    --
    Florian

    \
     
     \ /
      Last update: 2023-03-27 00:32    [W:4.050 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site