Messages in this thread | | | Date | Wed, 22 Feb 2023 14:57:10 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v1 04/10] ASoC: tegra: Support RT5631 by machine driver |
| |
On Wed, Feb 22, 2023 at 04:28:09PM +0300, Dan Carpenter wrote: > On Wed, Feb 22, 2023 at 09:55:52AM +0200, Svyatoslav Ryhel wrote: > > вт, 21 лют. 2023 р. о 21:32 Dan Carpenter <error27@gmail.com> пише:
> > > > /* Mic Jack */
> > > This comment doesn't make sense now. It was never super useful, though. > > > Just delete it.
> > It does. Headset is Mic Jack + Headphones combined. headset_check function > > performs check for a Mic Jack component in plugged Jack 3.5
> I feel if we need to discuess what a comment means or if it even means > anything then that's a useless comment by definition.
If the device doesn't have a distinct mic jack then it's not ideal to talk about there being one (as opposed to the microphone on the headset jack). [unhandled content-type:application/pgp-signature] | |