Messages in this thread | | | Date | Wed, 22 Feb 2023 20:46:04 -0700 | Subject | Re: [PATCH tools/io_uring] tools/io_uring: correctly set "ret" for sq_poll case | From | Jens Axboe <> |
| |
On 2/21/23 12:37?AM, Ziyang Zhang wrote: > For sq_poll case, "ret" is not initialized or cleared/set. In this way, > output of this test program is incorrect and we can not even stop this > program by pressing CTRL-C. > > Reset "ret" to zero in each submission/completion round, and assign > "ret" to "this_reap".
Can you check if this issue also exists in the fio copy of this, which is t/io_uring.c in:
git://git.kernel.dk/fio
The copy in the kernel is pretty outdated at this point, and should probably get removed. But if the bug is in the above main version, then we should fix it there and then ponder if we want to remove the one in the kernel or just get it updated to match the upstream version.
-- Jens Axboe
| |