Messages in this thread | | | Date | Wed, 22 Feb 2023 17:36:57 -0800 | From | Luis Chamberlain <> | Subject | Re: [PATCH 11/27] kbuild, clk: bcm2835: remove MODULE_LICENSE in non-modules |
| |
On Wed, Feb 22, 2023 at 03:43:40PM -0800, Stephen Boyd wrote: > Quoting Nick Alcock (2023-02-22 04:14:37) > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > > are used to identify modules. As a consequence, uses of the macro > > in non-modules will cause modprobe to misidentify their containing > > object file as a module when it is not (false positives), and modprobe > > might succeed rather than failing with a suitable error message. > > > > So remove it in the files in this commit, none of which can be built as > > modules. > > > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > > Cc: Luis Chamberlain <mcgrof@kernel.org> > > Cc: linux-modules@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Stephen Boyd <sboyd@kernel.org> > > Cc: Florian Fainelli <f.fainelli@gmail.com> > > Cc: Ray Jui <rjui@broadcom.com> > > Cc: Scott Branden <sbranden@broadcom.com> > > Cc: linux-clk@vger.kernel.org > > Cc: linux-rpi-kernel@lists.infradead.org > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Unless you want me to pick this up?
Up to you, you can pick it up, and by rc3 of the next kernel I pick up the last stragglers that no one picks up as reflected on linux-next.
Luis
| |