lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT
On Tue, Feb 21, 2023 at 12:46:07PM +0000, Jiaxun Yang wrote:
> As now we are always managing DMA coherence on per dev bias,
> there is no need to have such option. And it's not selected
> by any platform.

I think the real point here is that this is dead code, so it can
obviously go away, but:

> config MIPS_GENERIC_KERNEL
> bool "Generic board-agnostic MIPS kernel"
> - select ARCH_HAS_SETUP_DMA_OPS
> select MIPS_GENERIC
> select BOOT_RAW
> select BUILTIN_DTB
> @@ -1079,11 +1078,6 @@ config FW_CFE
> config ARCH_SUPPORTS_UPROBES
> bool

> @@ -1097,6 +1091,7 @@ config DMA_NONCOHERENT
> select ARCH_HAS_DMA_PREP_COHERENT
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_HAS_DMA_SET_UNCACHED
> + select ARCH_HAS_SETUP_DMA_OPS

This is an unrelated und undocument change. If you want to do it,
please do that as a separate patch with a commit log documenting
the rationale.

\
 
 \ /
  Last update: 2023-03-27 00:30    [W:0.356 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site