lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource()
From


On 2023/2/16 PM2:34, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/perf/alibaba_uncore_drw_pmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index a7689fecb49d..5c5be9fc1b15 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -656,8 +656,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev)
> drw_pmu->dev = &pdev->dev;
> platform_set_drvdata(pdev, drw_pmu);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - drw_pmu->cfg_base = devm_ioremap_resource(&pdev->dev, res);
> + drw_pmu->cfg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(drw_pmu->cfg_base))
> return PTR_ERR(drw_pmu->cfg_base);
>

LGTM. Thank you.

Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>

Best Regards,
Shuai

\
 
 \ /
  Last update: 2023-03-27 00:29    [W:0.034 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site