Messages in this thread | | | From | <> | Subject | Re: [PATCH v2 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding | Date | Tue, 21 Feb 2023 10:52:54 +0000 |
| |
On 21.02.2023 11:23, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 21/02/2023 09:10, Claudiu.Beznea@microchip.com wrote: >> On 21.02.2023 00:56, Rob Herring wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On Fri, Feb 17, 2023 at 02:41:50PM +0200, Claudiu Beznea wrote: >>>> Add microchip,startup-delay-us binding to let PDMC users to specify >>>> startup delay. >>> >>> The diff tells me all this. Why does this need to be per platform? >> >> PDMC can work with different kind of microphones, thus different boards >> could have different microphones. Depending on microphone type the PDMC >> would need to wait longer or shorter period than the default chosen period >> to filter unwanted noise. Thus the need of having this specified though >> device tree. Would you prefer to have this in commit message? > > I believe you also had explain it to me, thus as you can see having it > in commit msg would spare you two questions...
Right, I'll add it in the next version.
Thank you, Claudiu
> > Best regards, > Krzysztof >
| |