Messages in this thread | | | Date | Tue, 21 Feb 2023 17:55:14 +0800 | Subject | Re: [PATCH v2] scsi: ufs: core: Add trace event for MCQ | From | Ziqi Chen <> |
| |
Hi Bean,
looks reasonable,I will update in next version. Thanks~
On 2/21/2023 5:49 PM, Bean Huo wrote: > On 21.02.23 7:07 AM, Ziqi Chen wrote: >> + >> + TP_printk( >> + "%s: %s: tag: %u, hwq_id: %d, size: %d, IS: %u, LBA: %llu, >> opcode: 0x%x (%s), group_id: 0x%x, sq_tail_slot: %d, cq_head_slot: >> %d, cq_tail_slot: %d", > > Hi Ziqi, > > Looks good to me, just one thing, the above print strings can be > shortened? > > hwq_id-->hdid > sq_tail_slot-->sqt > cq_tail_slot->sqt > cq_head_slot->cqh > > > Kind regards, > Bean > >> + show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name), >> + __entry->tag, __entry->hwq_id, __entry->transfer_len, >> + __entry->intr, __entry->lba, (u32)__entry->opcode, >> + str_opcode(__entry->opcode), (u32)__entry->group_id, >> + __entry->sq_tail, __entry->cq_head, __entry->cq_tail >> + )
Best Regards,
Ziqi
| |