lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 22/29] LoongArch: KVM: Implement handle idle exception
From
Date


在 2023年02月21日 02:40, Paolo Bonzini 写道:
> On 2/20/23 07:57, Tianrui Zhao wrote:
>> +int _kvm_emu_idle(struct kvm_vcpu *vcpu)
>> +{
>> + ++vcpu->stat.idle_exits;
>> + trace_kvm_exit(vcpu, KVM_TRACE_EXIT_IDLE);
>
> Please add a separate tracepoint, don't overload trace_kvm_exit().
>
> Likewise for _kvm_trap_handle_gspr().
>
> I think _kvm_trap_handle_gspr() should have a tracepoint whose
> parameter is inst.word.

Thanks, I will add the tracepoint for _kvm_emu_idle and
_kvm_trap_handle_gspr.

Thanks
Tianrui Zhao

>
> Paolo
>
>> + if (!vcpu->arch.irq_pending) {
>> + kvm_save_timer(vcpu);
>> + kvm_vcpu_block(vcpu);
>> + }
>> +
>> + return EMULATE_DONE;

\
 
 \ /
  Last update: 2023-03-27 00:29    [W:0.097 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site