lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [EXTERNAL] Re: [PATCH v10 1/9] dt-bindings: mfd: ti, j721e-system-controller: Fix mux node regex
From


On 21/02/23 10:34 pm, Rob Herring wrote:
> On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote:
>>> mux-controller nodes may not have "reg" property. Update the regex
>>> for such nodes to resolve the dtbs warnings
>>>
>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>> ---
>
> Where's the change history? I doubt I ignored the last 9 versions...

This change was added newly in v8.
But based on the review comments, dtbs warnings can be fixed without
changes to bindings document. So this patch will be dropped in the next
series.

Ravi

>
>>> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> index 76ef4352e13c..532bfa45e6a0 100644
>>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> @@ -45,7 +45,7 @@ properties:
>>>
>>> patternProperties:
>>> # Optional children
>>> - "^mux-controller@[0-9a-f]+$":
>>> + "^mux-controller(@|-)[0-9a-f]+$":
>>
>> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to
>> mux-controller node in 2/9 ?
>
> Yes, do that.
>
> Rob


\
 
 \ /
  Last update: 2023-03-27 00:32    [W:0.461 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site