lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Update documentation of vfs_tmpfile
From
On 2/22/23 08:15, Hok Chun NG (Ben) wrote:
> Hi Bagas,
>
>> On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote:
>>> On function vfs_tmpfile, documentation is updated according to function signature update.
>>>
>>> Description for 'dentry' and 'open_flag' removed.
>>> Description for 'parentpath' and 'file' added.
>>
>> What commit did vfs_tmpfile() change its signature?
>
> Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6
> vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@redhat.com
>

Nice.

The preferred git pretty format when referring to existing commit is
"%h (\"%s\")". Make sure that you set core.abbrev to at least 12.

>>
>> For the patch description, I'd like to write "Commit <commit> changes
>> function signature for vfs_tmpfile(). Catch the function documentation
>> up with the change."
>
> I agree. Thank you for the suggestion.
>

OK, thanks!

--
An old man doll... just what I always wanted! - Clara

\
 
 \ /
  Last update: 2023-03-27 00:31    [W:0.033 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site