lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m
On Tue, Feb 21, 2023 at 06:19:19PM +0100, Adam Borowski wrote:
> ld: crypto/asymmetric_keys/selftest.o: in function `fips_signature_selftest':
> selftest.c:(.init.text+0xcd): undefined reference to `pkcs7_parse_message'

... and a fix for this has just been applied, I somehow missed it being on
the way. That's 0f5d4a0b995faa6537c4de79973817a4f8da206a which wasn't yet
in yesterday evening's pull.

Sorry for noise.

> ld: selftest.c:(.init.text+0x103): undefined reference to `pkcs7_supply_detached_data'
> ld: selftest.c:(.init.text+0x10d): undefined reference to `pkcs7_verify'
> ld: selftest.c:(.init.text+0x135): undefined reference to `pkcs7_validate_trust'
> ld: selftest.c:(.init.text+0x157): undefined reference to `pkcs7_free_message'
>
> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
> This fail still happens on randconfig runs.
>
> v2: expanded the Fixes tag to include that commit's subject
>
> crypto/asymmetric_keys/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 3df3fe4ed95f..fe007db96c69 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
> for FIPS.
> depends on KEYS
> depends on ASYMMETRIC_KEY_TYPE
> - depends on PKCS7_MESSAGE_PARSER
> + depends on PKCS7_MESSAGE_PARSER=y
>
> endif # ASYMMETRIC_KEY_TYPE
> --

Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Q: Is it ok to combine wired, wifi, and/or bluetooth connections
⢿⡄⠘⠷⠚⠋⠀ in wearable computing?
⠈⠳⣄⠀⠀⠀⠀ A: No, that would be mixed fabric, which Lev19:19 forbids.

\
 
 \ /
  Last update: 2023-03-27 00:30    [W:5.971 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site