Messages in this thread | | | Date | Mon, 20 Feb 2023 18:09:32 +1100 | From | Orlando Chamberlain <> | Subject | Re: [PATCH v4 2/2] HID: hid-apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards |
| |
On Sun, 19 Feb 2023 16:09:26 +0200 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sat, Feb 18, 2023 at 11:08 AM Orlando Chamberlain > <orlandoch.dev@gmail.com> wrote: > > > > This driver adds support for the keyboard backlight on Intel T2 Macs > > with internal Magic Keyboards (MacBookPro16,x and MacBookAir9,1) > > ... > > > + help > > + Say Y here if you want support for the keyboard backlight > > on Macs with > > + the magic keyboard (MacBookPro16,x and MacBookAir9,1). Note > > that this > > + driver is not for external magic keyboards. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called hid-apple-magic-backlight. > > Is it my email client or is the indentation of the help text > incorrect? > > Hint: the text of the help should be <TAB><SPACE><SPACE> indented. > > I believe checkpatch.pl at least in --strict mode should complain > about this.
Looking at the hid Kconfig, it seems like some have it as you've described, and some just have tab (and a few have just tab for the first line, and tab space space for the rest of the lines).
checkpatch.pl --strict didn't complain about the indentation so hopefully it's alright as is.
| |