lkml.org 
[lkml]   [2023]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v1 3/4] net: phy: do not force EEE support
    On Mon, Feb 20, 2023 at 04:48:26PM +0100, Andrew Lunn wrote:
    > > Hm.. ethtool do not provide enough information about expected behavior.
    > > Here is my expectation:
    > > - "ethtool --set-eee lan1 eee on" should enable EEE if it is disabled.
    > > - "ethtool --set-eee lan1 advertise 0x10" should change set of
    > > advertised modes.
    > > - a sequence of "..advertise 0x10", "..eee on", "eee off" should restore
    > > preconfigured advertise modes. advertising_eee instead of
    > > supported_eee.
    >
    > I agree ethtool is not very well documented. However, i would follow
    > what -s does. You can pass link modes you want to advertise, and you
    > can turn auto-neg on and off. Does turning auto-neg off and on again
    > reset the links modes which are advertised? I don't actually know, but
    > i think the behaviour should be consistent for link modes and EEE
    > modes.

    Hm.. "ethtool -s lan1 autoneg on" will restore supported values. Even
    without switching it off.
    In this case "eee on", supported_eee should be used.
    --
    Pengutronix e.K. | |
    Steuerwalder Str. 21 | http://www.pengutronix.de/ |
    31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

    \
     
     \ /
      Last update: 2023-03-27 00:29    [W:2.967 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site