lkml.org 
[lkml]   [2023]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v1 3/4] net: phy: do not force EEE support
> > >  		if (data->advertised)
> > > - adv[0] = data->advertised;
> > > - else
> > > - linkmode_copy(adv, phydev->supported_eee);
> > > + phydev->advertising_eee[0] = data->advertised;
> >
> > Is there a reason not to use ethtool_convert_legacy_u32_to_link_mode()?
> > I'm guessing this will be more efficient.
>
> Or at leas more readable. I'll update it.

I read that and had a similar reaction to Russell. Please do use the
helper.

Andrew

\
 
 \ /
  Last update: 2023-03-27 00:29    [W:0.063 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site