Messages in this thread | | | Date | Mon, 20 Feb 2023 16:32:28 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v1 3/4] net: phy: do not force EEE support |
| |
> > > if (data->advertised) > > > - adv[0] = data->advertised; > > > - else > > > - linkmode_copy(adv, phydev->supported_eee); > > > + phydev->advertising_eee[0] = data->advertised; > > > > Is there a reason not to use ethtool_convert_legacy_u32_to_link_mode()? > > I'm guessing this will be more efficient. > > Or at leas more readable. I'll update it.
I read that and had a similar reaction to Russell. Please do use the helper.
Andrew
| |