Messages in this thread | | | Date | Mon, 20 Feb 2023 14:58:27 +0100 | Subject | Re: [PATCH] scsi: ufs: Add select to CONFIG_PM in Kconfig | From | AngeloGioacchino Del Regno <> |
| |
Il 20/02/23 09:32, Stephen Zhang ha scritto: > From: Shida Zhang <zhangshida@kylinos.cn> > > From: Shida Zhang <zhangshida@kylinos.cn> > > In a configuration with CONFIG_SCSI_UFS_MEDIATEK set to 'm' and > CONFIG_PM set to 'n', errors occur at compile time: > > ==== > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_suspend’: > ../drivers/ufs/host/ufs-mediatek.c:1621:8: error: implicit declaration of function ‘ufshcd_runtime_suspend’; did you mean ‘ufs_mtk_runtime_suspend’? [-Werror=implicit-function-declaration] > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_resume’: > ../drivers/ufs/host/ufs-mediatek.c:1636:9: error: implicit declaration of function ‘ufshcd_runtime_resume’; did you mean ‘ufs_mtk_runtime_resume’? [-Werror=implicit-function-declaration] > ==== >
That's wrong. This driver should be made to compile for both !CONFIG_PM and CONFIG_PM.
Regards, Angelo
> This patch fixes these by selecting CONFIG_PM from CONFIG_SCSI_UFS_MEDIATEK. > > Reported-by: k2ci <kernel-bot@kylinos.cn> > Signed-off-by: Shida Zhang <zhangshida@kylinos.cn> > --- > drivers/ufs/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig > index 4cc2dbd79ed0..f9786f085b54 100644 > --- a/drivers/ufs/host/Kconfig > +++ b/drivers/ufs/host/Kconfig > @@ -71,6 +71,7 @@ config SCSI_UFS_QCOM > config SCSI_UFS_MEDIATEK > tristate "Mediatek specific hooks to UFS controller platform driver" > depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK > + select PM > select PHY_MTK_UFS > select RESET_TI_SYSCON > help
| |