lkml.org 
[lkml]   [2023]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/4] extcon: Removed redundant null checking for class
    Date
    create_extcon_class() is already Null checking.

    Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
    ---
    drivers/extcon/extcon.c | 21 ++++++++++-----------
    1 file changed, 10 insertions(+), 11 deletions(-)

    diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
    index e1c71359b605..adcf01132f70 100644
    --- a/drivers/extcon/extcon.c
    +++ b/drivers/extcon/extcon.c
    @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);

    static int create_extcon_class(void)
    {
    - if (!extcon_class) {
    - extcon_class = class_create(THIS_MODULE, "extcon");
    - if (IS_ERR(extcon_class))
    - return PTR_ERR(extcon_class);
    - extcon_class->dev_groups = extcon_groups;
    - }
    + if (extcon_class)
    + return 0;
    +
    + extcon_class = class_create(THIS_MODULE, "extcon");
    + if (IS_ERR(extcon_class))
    + return PTR_ERR(extcon_class);
    + extcon_class->dev_groups = extcon_groups;

    return 0;
    }
    @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
    int ret, index = 0;
    static atomic_t edev_no = ATOMIC_INIT(-1);

    - if (!extcon_class) {
    - ret = create_extcon_class();
    - if (ret < 0)
    - return ret;
    - }
    + ret = create_extcon_class();
    + if (ret < 0)
    + return ret;

    if (!edev || !edev->supported_cable)
    return -EINVAL;
    --
    2.35.1
    \
     
     \ /
      Last update: 2023-03-27 00:28    [W:3.419 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site