lkml.org 
[lkml]   [2023]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] scsi: ufs: ufs-mediatek: guard ufs_mtk_runtime_suspend() and ufs_mtk_runtime_resume() w/ CONFIG_PM
Hi Yangtao,

On Mon, Feb 20, 2023 at 10:44 PM Yangtao Li <frank.li@vivo.com> wrote:
>
> To fix below compile error(CONFIG_PM set to 'n'):
>
> drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_suspend`:
> drivers/ufs/host/ufs-mediatek.c:1623:8: error: implicit declaration of
> function `ufshcd_runtime_suspend`; did you mean `ufs_mtk_runtime_suspend`?
> [-Werror=implicit-function-declaration]
> 1623 | ret = ufshcd_runtime_suspend(dev);
> | ^~~~~~~~~~~~~~~~~~~~~~
> | ufs_mtk_runtime_suspend
> drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_resume`:
> drivers/ufs/host/ufs-mediatek.c:1638:9: error: implicit declaration of function
> `ufshcd_runtime_resume`; did you mean `ufs_mtk_runtime_resume`?
> [-Werror=implicit-function-declaration]
> 1638 | return ufshcd_runtime_resume(dev);
> | ^~~~~~~~~~~~~~~~~~~~~
> | ufs_mtk_runtime_resume
> At top level:
> drivers/ufs/host/ufs-mediatek.c:1632:12: error: `ufs_mtk_runtime_resume`
> defined but not used [-Werror=unused-function]
> 1632 | static int ufs_mtk_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/ufs/host/ufs-mediatek.c:1618:12: error: `ufs_mtk_runtime_suspend`
> defined but not used [-Werror=unused-function]
> 1618 | static int ufs_mtk_runtime_suspend(struct device *dev)
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Reported-by: Shida Zhang <zhangshida@kylinos.cn>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Thanks for this fix.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>

\
 
 \ /
  Last update: 2023-03-27 00:29    [W:1.111 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site