Messages in this thread | | | Date | Thu, 2 Feb 2023 11:17:27 +0000 | Subject | Re: [PATCH] firmware: qcom_scm: modify qcom_scm_set_download_mode() | From | Srinivas Kandagatla <> |
| |
On 24/01/2023 12:19, Mukesh Ojha wrote: > -static int __qcom_scm_set_dload_mode(struct device *dev, bool enable) > +static int __qcom_scm_set_dload_mode(struct device *dev, enum qcom_download_mode mode) > { > struct qcom_scm_desc desc = { > .svc = QCOM_SCM_SVC_BOOT, > .cmd = QCOM_SCM_BOOT_SET_DLOAD_MODE, > .arginfo = QCOM_SCM_ARGS(2), > - .args[0] = QCOM_SCM_BOOT_SET_DLOAD_MODE, > + .args[0] = mode,
Is this a bug fix? why are we changing arg[0]?
--srini > .owner = ARM_SMCCC_OWNER_SIP, > }; > > - desc.args[1] = enable ? QCOM_SCM_BOOT_SET_DLOAD_MODE : 0; > + desc.args[1] = mode; > > return qcom_scm_call_atomic(__scm->dev, &desc, NULL); > }
| |